[Fix] TestFlight iOS 백그라운드 푸시 미수신 버그 수정#185
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 본 PR은 iOS TestFlight 환경에서 백그라운드 푸시 알림이 수신되지 않던 문제를 해결하기 위한 변경 사항을 담고 있습니다. FCM 메시지 전송 시 APNs 환경 헤더가 누락되었던 점을 보완하고, 환경 변수를 통해 배포 환경에 맞는 설정을 적용할 수 있도록 개선하여 푸시 알림의 안정성을 확보했습니다. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
이번 PR은 FCM 발송 시 APNs 환경 설정을 동적으로 처리하기 위해 apns-environment 헤더를 추가하고 관련 설정을 application.yaml에 반영하는 변경사항을 담고 있습니다. 리뷰어는 APNs 및 FCM에서 개발 환경을 나타내는 올바른 헤더 값은 sandbox가 아닌 development이므로, 로컬 환경의 FCM_APNS_ENVIRONMENT 설정값을 development로 수정해야 함을 지적했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| fcm: | ||
| apns-environment: ${FCM_APNS_ENVIRONMENT:production} |
There was a problem hiding this comment.
APNs의 apns-environment 헤더 값으로 sandbox 대신 development를 사용해야 합니다. Apple APNs 및 FCM에서 인식하는 개발 환경의 올바른 헤더 값은 development와 production입니다. PR 본문에 local: sandbox로 설정하셨다고 언급되어 있는데, 이 경우 개발 환경에서 백그라운드 푸시가 정상적으로 수신되지 않을 수 있습니다. local 환경의 FCM_APNS_ENVIRONMENT 값을 development로 변경해 주세요.
1 participant
🧾 요약
🔗 이슈
✨ 변경 내용
FcmService에apns-environment헤더 추가 (백그라운드/일반 알림 모두 적용)dataOnly=false) 경로에ApnsConfig누락 추가application.yaml에fcm.apns-environment환경변수 분리 (prod 기본값:production, local:sandbox)✅ 확인